Merged
Conversation
4 tasks
Owner
There was a problem hiding this comment.
I think not should be removed in this sentence.
Owner
|
Thanks @spalger ! Let me test on my end to see if I understand everything and i'll merge. |
| obj.fact('type'); | ||
| obj.writ('count', spec.count || 0); | ||
| obj.writ('exclude', spec.exclude); | ||
| obj.fact('exclude', Boolean(!isMetaField && spec.exclude)); |
Owner
|
LGTM, I will merge when the small issue of the tooltip is resolved. |
Author
|
@scampi update made 🌠 |
scampi
added a commit
that referenced
this pull request
Jan 21, 2016
scampi
pushed a commit
that referenced
this pull request
Apr 13, 2016
[discover/tests] update rigid test data
scampi
pushed a commit
that referenced
this pull request
Apr 13, 2016
Move kbn-loading-indicator to element
scampi
pushed a commit
that referenced
this pull request
Sep 16, 2016
scampi
pushed a commit
that referenced
this pull request
Dec 11, 2017
* quick panel moved to directive * move relative to directive * move absolute to directive * move stuff from timepicker directive to new directives * move timepicker to right with flexbox * remove left padding for kbn-timepicker-section * merge in timepicker.html changes from - Improve accessibility of the Datepicker. (elastic#11753) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds (#1) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds, so the content doesn't jump around as you switch modes.. * Make kbn-timepicker-content responsive so that it stacks content on narrower screens. * Combine Relative input and select fields using kuiFieldGroup. * Make Timepicker submit button wider. * Align button on right. * migrate inputs from form-control to kui classes * update generated dist/ui_framework.css * fix broken tests * create kbn-timerpicker-nav-button class and update kbn-timepicker-section to make each column the same width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I played around with this this branch for a while and made a couple tweaks that I think improve elastic#5881
@message.raw).field.excludeis accurate