-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/zenko 4903 fix drctl status flaky #2161
Conversation
Hello killiang,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
9f3b62b
to
129afee
Compare
0b2f246
to
cc97c7d
Compare
/force_reset |
Reset completeI have successfully deleted this pull request's integration branches. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
.github/workflows/end2end.yaml
Outdated
- ubuntu | ||
- focal | ||
- xlarge | ||
- ubuntu-22.04-8core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we actually need the larger workers?
(esp. this is one on e2e-http and e2e-https which are not overloaded?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This move is about x2 in RAM and CPU, for a doubled price, see https://devdocs.scality.net/ci-engines/github-actions/runners/?h=ubuntu+22.04+8core#github-hosted-larger-pools-of-runners , as xlarge (see https://github.com/scality/devinfra/blob/main/manifests/runner-manager/overlays/prod/runner-manager.yaml#L91-L100 and https://cloud.google.com/compute/vm-instance-pricing#compute-optimized_machine_types for e2-standard-4
) is equivalent to ubuntu-22.04-4core
I'm totally fine doing it if this is the right move, but how do we jump to this conclusion exactly? (quickly looked at the ticket and the rest of the PR but I don't see anything obvious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For e2e-http and e2e-https we can probably use ubuntu-22.04-4core
but we still need to jump to ubuntu 22.04 otherwise k8s bump and dependencies wont work..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KillianG then I would recommend to use a new runner but stay within the current specs; bumping a runner to a more powerful machine should be done if you experience network flakiness, memory issues, disk limits, ... stuff that should be visible in the logs
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Issue: ZENKO-4903
…not to find the object Issue: ZENKO-4903
cc97c7d
to
cbe6ff0
Compare
What does this PR do, and why do we need it?
Which issue does this PR fix?
fixes #
Special notes for your reviewers: