Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/zenko 4903 fix drctl status flaky #2161

Merged
4 commits merged into from
Oct 24, 2024

Conversation

KillianG
Copy link
Contributor

@KillianG KillianG commented Oct 3, 2024

What does this PR do, and why do we need it?

Which issue does this PR fix?

fixes #

Special notes for your reviewers:

@bert-e
Copy link
Contributor

bert-e commented Oct 3, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@KillianG KillianG force-pushed the bugfix/ZENKO-4903-fix-drctl-status-flaky branch from 9f3b62b to 129afee Compare October 3, 2024 14:45
@KillianG KillianG force-pushed the bugfix/ZENKO-4903-fix-drctl-status-flaky branch 4 times, most recently from 0b2f246 to cc97c7d Compare October 4, 2024 16:02
@scality scality deleted a comment from bert-e Oct 7, 2024
@scality scality deleted a comment from bert-e Oct 7, 2024
@scality scality deleted a comment from bert-e Oct 7, 2024
@scality scality deleted a comment from bert-e Oct 7, 2024
@nootal
Copy link

nootal commented Oct 7, 2024

/force_reset

@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2024

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@scality scality deleted a comment from bert-e Oct 7, 2024
@scality scality deleted a comment from bert-e Oct 7, 2024
@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

solution/deps.yaml Outdated Show resolved Hide resolved
- ubuntu
- focal
- xlarge
- ubuntu-22.04-8core
Copy link
Contributor

@francoisferrand francoisferrand Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we actually need the larger workers?
(esp. this is one on e2e-http and e2e-https which are not overloaded?)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This move is about x2 in RAM and CPU, for a doubled price, see https://devdocs.scality.net/ci-engines/github-actions/runners/?h=ubuntu+22.04+8core#github-hosted-larger-pools-of-runners , as xlarge (see https://github.com/scality/devinfra/blob/main/manifests/runner-manager/overlays/prod/runner-manager.yaml#L91-L100 and https://cloud.google.com/compute/vm-instance-pricing#compute-optimized_machine_types for e2-standard-4 ) is equivalent to ubuntu-22.04-4core
I'm totally fine doing it if this is the right move, but how do we jump to this conclusion exactly? (quickly looked at the ticket and the rest of the PR but I don't see anything obvious)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For e2e-http and e2e-https we can probably use ubuntu-22.04-4core but we still need to jump to ubuntu 22.04 otherwise k8s bump and dependencies wont work..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KillianG then I would recommend to use a new runner but stay within the current specs; bumping a runner to a more powerful machine should be done if you experience network flakiness, memory issues, disk limits, ... stuff that should be visible in the logs

@scality scality deleted a comment from nootal Oct 22, 2024
@scality scality deleted a comment from bert-e Oct 22, 2024
@bert-e
Copy link
Contributor

bert-e commented Oct 22, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@francoisferrand francoisferrand force-pushed the bugfix/ZENKO-4903-fix-drctl-status-flaky branch from cc97c7d to cbe6ff0 Compare October 22, 2024 07:56
@bert-e bert-e closed this pull request by merging all changes into development/2.6 in 925e86d Oct 24, 2024
@bert-e bert-e deleted the bugfix/ZENKO-4903-fix-drctl-status-flaky branch October 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants