Bugfix/zenko 4909 #2157
Bugfix/zenko 4909 #2157
Conversation
- Otherwise, we might be overloading the Vault service with multiple API calls at high frequency. Issue: ZENKO-4909
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: approve |
| @@ -296,6 +296,9 @@ When('the DATA_ACCESSOR user tries to perform PutObject on {string} site', { tim | |||
| } catch (err) { | |||
| this.logger.error('Failed to setup entity', { err }); | |||
| } | |||
| if (!conditionOk) { | |||
| await Utils.sleep(1000); | |||
There was a problem hiding this comment.
Would be nice to explain the delay here, in the code: for people stumbling upon it in the future
There was a problem hiding this comment.
Will be done in the ticket targeting all branches - but not sure it's needed to have a comment, it's not mandatory, just to avoid calling APIs in a while loop without sleep times...
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-4909. Goodbye williamlardier. The following options are set: approve |
Fixes the error in the CI, that blocked the last 2.10 bump: with the previous override on sorbet's s3 endpoint, it was always using the SOURCE endpoint to restore objects, causing errors when we were trying to do it during a failover phase, when the restore is expected to take place in the SINK.