Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache env variables #2280

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Cache env variables #2280

merged 4 commits into from
Jan 20, 2025

Conversation

francoisferrand
Copy link
Contributor

Reading env variables is costly, so do it only once on startup.

Issue: ARSN-442

francoisferrand and others added 4 commits January 11, 2025 09:18
Reading env variables is costly, so do it only once on startup.

Issue: ARSN-442
Reading env variables is costly, so do it only once on startup.

Issue: ARSN-442
Reading env variables is costly, so do it only once on startup.

Issue: ARSN-442
@bert-e
Copy link
Contributor

bert-e commented Jan 17, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Jan 17, 2025
@bert-e
Copy link
Contributor

bert-e commented Jan 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francoisferrand
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-442.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 756a42d into development/8.2 Jan 20, 2025
7 checks passed
@bert-e bert-e deleted the improvement/ARSN-442 branch January 20, 2025 16:50
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.33%. Comparing base (07efddd) to head (756a42d).
Report is 4 commits behind head on development/8.2.

Files with missing lines Patch % Lines
lib/s3middleware/processMpuParts.ts 16.66% 5 Missing ⚠️
...orage/metadata/mongoclient/MongoClientInterface.js 90.00% 2 Missing ⚠️
lib/auth/v2/queryAuthCheck.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.2    #2280      +/-   ##
===================================================
+ Coverage            66.30%   66.33%   +0.03%     
===================================================
  Files                  215      215              
  Lines                17336    17340       +4     
  Branches              3555     3545      -10     
===================================================
+ Hits                 11494    11502       +8     
+ Misses                5827     5822       -5     
- Partials                15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants