Bucket quota should be treated and stored as BigInts #2279

williamlardier · 2025-01-17T13:24:27Z

Stored and treated as BigInt in the class. Accepted as string/number/Long (from a serialized object, or from an object), and outputted as a string for storage on the DB

Issue: ARSN-457

bert-e · 2025-01-17T13:24:30Z

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

The previous objects will be handled because we always convert incoming data (inDeSerialize and fromObj) to BigInts, which is working well if the value is a string, a number, or any mongodb- specific value. Issue: ARSN-457

Libcrypto was removed, plus other changes, not yet supported by Arsenal. Issue: ARSN-457

codecov · 2025-01-17T16:28:47Z

Codecov Report

Attention: Patch coverage is 77.29358% with 99 lines in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (a0927dc) to head (14b341d).
Report is 23 commits behind head on development/8.1.

Files with missing lines	Patch %	Lines
...orage/metadata/mongoclient/MongoClientInterface.ts	63.13%	94 Missing ⚠️
lib/models/BucketInfo.ts	94.00%	3 Missing ⚠️
lib/storage/metadata/mongoclient/utils.ts	97.80%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.1    #2279      +/-   ##
===================================================
+ Coverage            66.28%   66.41%   +0.12%     
===================================================
  Files                  215      216       +1     
  Lines                17329    17434     +105     
  Branches              3528     3556      +28     
===================================================
+ Hits                 11487    11578      +91     
- Misses                5827     5840      +13     
- Partials                15       16       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/auth/Vault.ts

lib/models/BucketInfo.ts

- Long in MongoDB - String when retrieved / serialized - BigInt locally Issue: ARSN-457

Issue: ARSN-457

- We were passing a test on serialize() thank to the global toJSON defined in the test, yet during execution time, we would not be able to serialize. We cannot use toJSON globally in this repo, because it would affect all projects importing it, and eventually lead to unexpected side effects. - The manual conversion to string must be carefully done: in nodejs, converting to json a bigint as a subfield of an object would change the base object in the class, and eventually we end up with "strings" instead of bigint, without typescript knowing about it. Issue: ARSN-457

lib/storage/metadata/mongoclient/MongoClientInterface.ts

bert-e · 2025-01-27T13:46:06Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

williamlardier · 2025-01-27T13:46:53Z

/create_integration_branches

bert-e · 2025-01-27T13:47:02Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.2/bugfix/ARSN-457 with contents from bugfix/ARSN-457
and development/8.2.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.2/bugfix/ARSN-457 origin/development/8.2
 $ git merge origin/bugfix/ARSN-457
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.2/bugfix/ARSN-457

The following options are set: create_integration_branches

Issue: ARSN-457

williamlardier · 2025-01-27T14:08:22Z

/reset

bert-e · 2025-01-27T14:08:28Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-01-27T14:14:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

Issue: ARSN-457

bert-e · 2025-01-27T16:40:14Z

History mismatch

Merge commit #9088efbb6a913d554023582a50c982e6ea835e94 on the integration branch
w/8.2/bugfix/ARSN-457 is merging a branch which is neither the current
branch bugfix/ARSN-457 nor the development branch
development/8.2.

It is likely due to a rebase of the branch bugfix/ARSN-457 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

williamlardier · 2025-01-28T10:05:41Z

/reset

bert-e · 2025-01-28T10:05:50Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-01-28T10:09:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

williamlardier · 2025-01-28T10:14:33Z

/approve

bert-e · 2025-01-28T10:14:49Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/8.1
✔️ development/8.2

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2025-01-28T10:23:00Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.1
✔️ development/8.2

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/7.70

Please check the status of the associated issue ARSN-457.

Goodbye williamlardier.

Configure project to accept latest BigInt-related notation

c50375c

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch 2 times, most recently from c625e7d to 9cd6ef0 Compare January 17, 2025 15:46

williamlardier added 2 commits January 17, 2025 16:55

Switch quotas to BigInt

16df786

The previous objects will be handled because we always convert incoming data (inDeSerialize and fromObj) to BigInts, which is working well if the value is a string, a number, or any mongodb- specific value. Issue: ARSN-457

Fix ubuntu runner os version to 22

4cfff62

Libcrypto was removed, plus other changes, not yet supported by Arsenal. Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch from 9cd6ef0 to 73e728b Compare January 17, 2025 15:55

williamlardier requested review from francoisferrand, KillianG, Kerkesni and benzekrimaha January 17, 2025 16:04

Kerkesni approved these changes Jan 20, 2025

View reviewed changes

KillianG approved these changes Jan 20, 2025

View reviewed changes

francoisferrand reviewed Jan 20, 2025

View reviewed changes

lib/auth/Vault.ts Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 20, 2025

View reviewed changes

lib/models/BucketInfo.ts Outdated Show resolved Hide resolved

williamlardier force-pushed the bugfix/ARSN-457 branch from 73e728b to 4938862 Compare January 20, 2025 17:41

williamlardier marked this pull request as draft January 21, 2025 08:10

williamlardier force-pushed the bugfix/ARSN-457 branch from 4938862 to 5185217 Compare January 21, 2025 08:23

Support SOSAPI metrics as large numbers

03b0373

- Long in MongoDB - String when retrieved / serialized - BigInt locally Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch 2 times, most recently from c3c3c10 to a3ccbef Compare January 22, 2025 11:07

Consistent types for Auth APIs

749bc00

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch 2 times, most recently from af69908 to c89d942 Compare January 22, 2025 11:20

Be lenient on the input BucketInfo type for bucket quota

3bed608

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch from c89d942 to 3d72875 Compare January 22, 2025 11:21

Accept bigint and numbers for the veeamsosapi capability

f6eb2c4

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch from 3d72875 to c3d5d2f Compare January 22, 2025 12:52

francoisferrand reviewed Jan 27, 2025

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 27, 2025

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.ts Show resolved Hide resolved

francoisferrand reviewed Jan 27, 2025

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated Show resolved Hide resolved

benzekrimaha approved these changes Jan 27, 2025

View reviewed changes

francoisferrand reviewed Jan 27, 2025

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.ts Show resolved Hide resolved

francoisferrand approved these changes Jan 27, 2025

View reviewed changes

williamlardier force-pushed the bugfix/ARSN-457 branch from 766ddff to 5382857 Compare January 27, 2025 13:34

scality deleted a comment from bert-e Jan 27, 2025

Update code post review

cf25b66

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch from 5382857 to 9088efb Compare January 27, 2025 14:03

scality deleted a comment from bert-e Jan 27, 2025

williamlardier added 2 commits January 27, 2025 17:39

Be more safe against undefined quota or capabilities fields

02ab640

Issue: ARSN-457

Bump project version

14b341d

Issue: ARSN-457

williamlardier force-pushed the bugfix/ARSN-457 branch from 9088efb to 14b341d Compare January 27, 2025 16:40

scality deleted a comment from bert-e Jan 28, 2025

bert-e merged commit 4431bbe into development/8.1 Jan 28, 2025
7 checks passed

bert-e deleted the bugfix/ARSN-457 branch January 28, 2025 10:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bucket quota should be treated and stored as BigInts #2279

Bucket quota should be treated and stored as BigInts #2279

williamlardier commented Jan 17, 2025

bert-e commented Jan 17, 2025

codecov bot commented Jan 17, 2025 •

edited

Loading

bert-e commented Jan 27, 2025

williamlardier commented Jan 27, 2025

bert-e commented Jan 27, 2025

williamlardier commented Jan 27, 2025

bert-e commented Jan 27, 2025

bert-e commented Jan 27, 2025

bert-e commented Jan 27, 2025

williamlardier commented Jan 28, 2025

bert-e commented Jan 28, 2025

bert-e commented Jan 28, 2025

williamlardier commented Jan 28, 2025

bert-e commented Jan 28, 2025

bert-e commented Jan 28, 2025

Bucket quota should be treated and stored as BigInts #2279

Bucket quota should be treated and stored as BigInts #2279

Conversation

williamlardier commented Jan 17, 2025

bert-e commented Jan 17, 2025

Hello williamlardier,

codecov bot commented Jan 17, 2025 • edited Loading

Codecov Report

bert-e commented Jan 27, 2025

Request integration branches

williamlardier commented Jan 27, 2025

bert-e commented Jan 27, 2025

Conflict

williamlardier commented Jan 27, 2025

bert-e commented Jan 27, 2025

Reset complete

bert-e commented Jan 27, 2025

Waiting for approval

bert-e commented Jan 27, 2025

History mismatch

williamlardier commented Jan 28, 2025

bert-e commented Jan 28, 2025

Reset complete

bert-e commented Jan 28, 2025

Waiting for approval

williamlardier commented Jan 28, 2025

bert-e commented Jan 28, 2025

In the queue

bert-e commented Jan 28, 2025

codecov bot commented Jan 17, 2025 •

edited

Loading