-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove supportedLifecycleRules from constants #2275
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2275 +/- ##
===================================================
- Coverage 64.91% 64.90% -0.01%
===================================================
Files 215 215
Lines 17299 17296 -3
Branches 3514 3512 -2
===================================================
- Hits 11229 11226 -3
Misses 6055 6055
Partials 15 15 ☔ View full report in Codecov by Sentry. |
supportedLifecycleRules' value is different between the 7.x and 8.x branches. We should define the rules directly in the config of the Zenko components. Issue: ARSN-435
6b86467
to
d7a63a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to bump the project version if needed in cloudserver
We probably want to wait for more meaningful changes (NodeJS 22 + dependency bumps) before releasing the 8.2 version. Cloudserver with it's current changes will still work with the previous version of Arsenal. |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-435. Goodbye kerkesni. |
supportedLifecycleRules' value is different between the 7.x and 8.x branches. We should define the rules directly in the config of the Zenko components.
Issue: ARSN-435