Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARSN-418 Cherry-pick change to fix CRR null version in Backbeat #2244

Merged
merged 2 commits into from
Jun 20, 2024
Merged

ARSN-418 Cherry-pick change to fix CRR null version in Backbeat #2244

merged 2 commits into from
Jun 20, 2024

Conversation

nicolas2bert
Copy link
Contributor

@nicolas2bert nicolas2bert commented Jun 18, 2024 •
edited
Loading

Cherry-picking from development/7.70 branch.
The code has already been reviewed.

Kerkesni and others added 2 commits June 18, 2024 13:53
@Kerkesni @nicolas2bert
bugfix: ARSN-278 handle getting versionId when object is versioning s…
361b546 
…uspended

When replicating a versioning suspended object, we need to specify 'null'
as the encoded versionId as the versionId contained within the object's
metadata is strictly internal

In the replication processor we use getVersionId() when putting/deleting a tag.
It's used by the mongoClient to fetch the object from MongoDB, here again we
need to specify 'null' to get the versioning suspended object (cloudserver already
knows how to handle 'null' versionId and transforms it to undefined before giving
it to the mongoClient)

(cherry picked from commit d1cd7e8)
(cherry picked from commit f13a5d7)
@nicolas2bert
ARSN-418 bump package version
d1d1409
@bert-e
Copy link
Contributor

bert-e commented Jun 18, 2024

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 18, 2024

Incorrect fix version

The Fix Version/s in issue ARSN-418 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 7.70.14.1

Please check the Fix Version/s of ARSN-418, or the target
branch of this pull request.

@nicolas2bert
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Jun 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Jun 20, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.70.14

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-418.

Goodbye nicolas2bert.

The following options are set: approve

@bert-e bert-e merged commit d1d1409 into hotfix/7.70.14 Jun 20, 2024
5 checks passed
@bert-e bert-e deleted the bugfix/ARSN-418/fix-crr-null-version branch June 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anurag4DSB anurag4DSB anurag4DSB approved these changes

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas2bert @bert-e @anurag4DSB @BourgoisMickael @Kerkesni