Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-404: adding permission in BP and IAM action Map #2232

Merged

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Mar 18, 2024

This pull request primarily focuses on adding new action maps related to bucket and account quotas. The changes allow for the handling of new actions such as getting, updating, and deleting bucket and account quotas.

Issue : ARSN-404

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Incorrect fix version

The Fix Version/s in issue ARSN-404 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.128

Please check the Fix Version/s of ARSN-404, or the target
branch of this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.99%. Comparing base (c2ab4a2) to head (ca8f570).

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.1    #2232   +/-   ##
================================================
  Coverage            64.98%   64.99%           
================================================
  Files                  213      213           
  Lines                17059    17061    +2     
  Branches              3496     3496           
================================================
+ Hits                 11086    11088    +2     
  Misses                5958     5958           
  Partials                15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-404-new-permission-for-quotas-apis branch from 757383d to b3a5ce5 Compare March 21, 2024 10:47
Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth having the version bump in the PR

@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-404-new-permission-for-quotas-apis branch 2 times, most recently from 2c5e54c to 3f995c5 Compare April 4, 2024 07:00
@benzekrimaha benzekrimaha force-pushed the improvement/ARSN-404-new-permission-for-quotas-apis branch from c78555c to ca8f570 Compare April 5, 2024 09:36
@benzekrimaha
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Apr 24, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 24, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-404.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit ca8f570 into development/8.1 Apr 24, 2024
5 checks passed
@bert-e bert-e deleted the improvement/ARSN-404-new-permission-for-quotas-apis branch April 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants