Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/arsn 223 fix wgm default import #1929

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Jun 10, 2022

Fixes the following error in CloudServer:

{
   "name":"S3",
   "time":1654847139646,
   "error":"WGM is not a constructor",
   "stack":"TypeError: WGM is not a constructor\n    at MetadataFileServer.initMetadataService (/usr/src/app/node_modules/arsenal/build/lib/storage/metadata/file/MetadataFileServer.js:206:21)\n    at MetadataFileServer.startServer (/usr/src/app/node_modules/arsenal/build/lib/storage/metadata/file/MetadataFileServer.js:117:14)\n    at Object.<anonymous> (/usr/src/app/mdserver.js:28:14)\n    at Module._compile (node:internal/modules/cjs/loader:1101:14)\n    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)\n    at Module.load (node:internal/modules/cjs/loader:981:32)\n    at Function.Module._load (node:internal/modules/cjs/loader:822:12)\n    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)\n    at node:internal/main/run_main_module:17:47",
   "level":"fatal",
   "message":"caught error",
   "hostname":"kw035-prod-cloudserver-backend-0-17604-8133",
   "pid":112
}

@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-223 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.53

Please check the Fix Version/s of ARSN-223, or the target
branch of this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #1929 (547eb7d) into development/8.1 (0e2071e) will not change coverage.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           development/8.1    #1929   +/-   ##
================================================
  Coverage            63.63%   63.63%           
================================================
  Files                  205      205           
  Lines                15447    15447           
  Branches              3094     3094           
================================================
  Hits                  9829     9829           
  Misses                5602     5602           
  Partials                16       16           
Impacted Files Coverage Δ
lib/storage/metadata/file/MetadataFileServer.js 14.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2071e...547eb7d. Read the comment docs.

@williamlardier williamlardier requested review from XinLi0207, a user, jbertran and KillianG June 10, 2022 08:47
@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand
Copy link
Contributor

as discussed, please target 7.x branch to fix the issue everywhere...

@williamlardier williamlardier force-pushed the bugfix/ARSN-223-fix-wgm-default-import branch from 547eb7d to 20a071f Compare June 10, 2022 09:20
@williamlardier williamlardier changed the base branch from development/8.1 to development/7.10 June 10, 2022 09:20
@scality scality deleted a comment from bert-e Jun 10, 2022
@scality scality deleted a comment from bert-e Jun 10, 2022
@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 10, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-223.

Goodbye williamlardier.

@bert-e bert-e merged commit 20a071f into development/7.10 Jun 10, 2022
@bert-e bert-e deleted the bugfix/ARSN-223-fix-wgm-default-import branch June 10, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants