Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-218: enable lifecycle noncurrent version transition #1922

Conversation

alexanderchan-scality
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented May 27, 2022

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 27, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@alexanderchan-scality alexanderchan-scality force-pushed the feature/ARSN-218/updateLifecycleConfigurationNoncurrentTransition branch from ced4688 to 15f0753 Compare May 28, 2022 08:27
@codecov-commenter
Copy link

Codecov Report

Merging #1922 (15f0753) into development/8.1 (e95d07a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           development/8.1    #1922   +/-   ##
================================================
  Coverage            63.62%   63.63%           
================================================
  Files                  205      205           
  Lines                15450    15447    -3     
  Branches              3095     3094    -1     
================================================
- Hits                  9830     9829    -1     
+ Misses                5604     5602    -2     
  Partials                16       16           
Impacted Files Coverage Δ
lib/constants.ts 100.00% <ø> (ø)
lib/models/LifecycleConfiguration.js 78.81% <ø> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95d07a...15f0753. Read the comment docs.

@alexanderchan-scality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 31, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 31, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-218.

Goodbye alexanderchan-scality.

@bert-e bert-e merged commit 15f0753 into development/8.1 May 31, 2022
@bert-e bert-e deleted the feature/ARSN-218/updateLifecycleConfigurationNoncurrentTransition branch May 31, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants