ARSN-200: fix probe server readiness path

[alexanderchan-scality]

No description provided.

[bert-e]

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-200 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.1.48

Please check the Fix Version/s of ARSN-200, or the target
branch of this pull request.

[miniscruff]

not that it matters much but using /live for both was my intention as we had only used one form of readiness at the time so I just implemented the one handler.

[codecov-commenter]

Codecov Report

Merging #1889 (86e9d4a) into development/8.1 (8eb7efd) will not change coverage.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           development/8.1    #1889   +/-   ##
================================================
  Coverage            62.99%   62.99%           
================================================
  Files                  199      199           
  Lines                15391    15391           
  Branches              3061     3061           
================================================
  Hits                  9696     9696           
  Misses                5694     5694           
  Partials                 1        1           

Impacted Files	Coverage Δ
lib/network/probe/ProbeServer.ts	23.33% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb7efd...86e9d4a. Read the comment docs.

[alexanderchan-scality]

@miniscruff I see. I had made this change as it was not backwards compatible with previous versions of backbeat images. I had probably missed the intention for the change since it was made as part of the typescript refactor.

[miniscruff]

@miniscruff I see. I had made this change as it was not backward compatible with previous versions of backbeat images. I had probably missed the intention for the change since it was made as part of the typescript refactor.

We should definitely do this change, just making a point as to why it was the way it was. It looks like a typo bug but was more of a shortcut. Just have to check backbeat uses to make sure the two routes are used properly.

[alexanderchan-scality]

/approve

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-200 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.1.48

Please check the Fix Version/s of ARSN-200, or the target
branch of this pull request.

The following options are set: approve

[alexanderchan-scality]

ping

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/8.1

The following branches will NOT be impacted:

• development/6.4
• development/7.10
• development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.1

The following branches have NOT changed:

• development/6.4
• development/7.10
• development/7.4

Please check the status of the associated issue ARSN-200.

Goodbye alexanderchan-scality.