Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-195: fix arsenal bugs and missing default in require #1882

Merged
merged 3 commits into from
May 9, 2022

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented May 9, 2022

This PR fixes some misses and bugs from #1844.

Related ANDON: https://scality.atlassian.net/browse/AN-136

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier williamlardier force-pushed the bugfix/ARSN-195-fix-ts-migration-bugs branch from 8d71ab8 to 75b68ac Compare May 9, 2022 12:39
@williamlardier williamlardier changed the base branch from development/8.1 to development/7.10 May 9, 2022 12:39
@williamlardier
Copy link
Contributor Author

/reset

@williamlardier williamlardier force-pushed the bugfix/ARSN-195-fix-ts-migration-bugs branch from 6c29c00 to 4594578 Compare May 9, 2022 12:58
@scality scality deleted a comment from bert-e May 9, 2022
@scality scality deleted a comment from bert-e May 9, 2022
@scality scality deleted a comment from bert-e May 9, 2022
@scality scality deleted a comment from bert-e May 9, 2022
@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs with contents from bugfix/ARSN-195-fix-ts-migration-bugs
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs origin/development/8.1
 $ git merge origin/bugfix/ARSN-195-fix-ts-migration-bugs
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs

@scality scality deleted a comment from bert-e May 9, 2022
@williamlardier
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs with contents from bugfix/ARSN-195-fix-ts-migration-bugs
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs origin/development/8.1
 $ git merge origin/bugfix/ARSN-195-fix-ts-migration-bugs
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/bugfix/ARSN-195-fix-ts-migration-bugs

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 9, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-195.

Goodbye williamlardier.

@bert-e bert-e merged commit 4594578 into development/7.10 May 9, 2022
@bert-e bert-e deleted the bugfix/ARSN-195-fix-ts-migration-bugs branch May 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants