ARSN-184 type check s3routes #1878

ghivert · 2022-05-06T12:47:19Z

No description provided.

bert-e · 2022-05-06T12:47:20Z

Hello ghivert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2022-05-06T12:47:23Z

Branches have diverged

This pull request's source branch feature/ARSN-184-type-check-s3routes has diverged from
development/8.1 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

Merge origin/development/8.1 into feature/ARSN-184-type-check-s3routes
Rebase feature/ARSN-184-type-check-s3routes onto origin/development/8.1

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

bert-e · 2022-05-06T12:48:05Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/feature/ARSN-184-type-check-s3routes with contents from feature/ARSN-184-type-check-s3routes
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/feature/ARSN-184-type-check-s3routes origin/development/8.1
 $ git merge origin/feature/ARSN-184-type-check-s3routes
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/feature/ARSN-184-type-check-s3routes

bert-e · 2022-05-06T13:19:34Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/ARSN-184-type-check-s3routes into
development/7.10
w/8.1/feature/ARSN-184-type-check-s3routes will be merged into development/8.1 (pull request INTEGRATION [PR#1878 > development/8.1] ARSN-184 type check s3routes #1879)

The following branches will NOT be impacted:

development/6.4
development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

bert-e · 2022-05-06T13:19:35Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

nicolas2bert

Looking good :)

nicolas2bert · 2022-05-24T12:50:09Z

lib/s3routes/routes/routePUT.ts

-            log.end().addDefaultFields({
-                contentLength: request.parsedContentLength,
-            });
+            // TODO What's happening?


What is the issue here? Do we have a ticket number related to this that we can add to the comments?

Perhaps we can blanket-add ARSN-174 references to these TODOs. These all to track the second pass required to understand the business logic to type these accurately.

nicolas2bert · 2022-05-24T12:52:40Z

lib/s3routes/routesUtils.ts

+    const parsedUrl = url.parse(request.url!, true);
+    // @ts-expect-error
+    request.query = parsedUrl.query;
+    // TODO: make the namespace come from a config variable.


It is a good practice to have TODO attached with a JIRA ticket number to track todos :)

This one comes from existing code 😬

bert-e · 2022-05-24T12:52:57Z

Conflict

There is a conflict between your branch feature/ARSN-184-type-check-s3routes and the
destination branch development/7.10.

Please resolve the conflict on the feature branch (feature/ARSN-184-type-check-s3routes).

git fetch && \
git checkout origin/feature/ARSN-184-type-check-s3routes && \
git merge origin/development/7.10

Resolve merge conflicts and commit

git push origin HEAD:feature/ARSN-184-type-check-s3routes

bert-e · 2022-05-25T09:27:34Z

Conflict

A conflict has been raised during the update of
integration branch w/8.1/feature/ARSN-184-type-check-s3routes with contents from feature/ARSN-184-type-check-s3routes
and development/8.1.

Please resolve the conflict on the integration branch (w/8.1/feature/ARSN-184-type-check-s3routes).

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout w/8.1/feature/ARSN-184-type-check-s3routes
 $ git pull  # or "git reset --hard origin/w/8.1/feature/ARSN-184-type-check-s3routes"
 $ git merge origin/development/8.1
 $ # <intense conflict resolution>
 $ git commit
 $ git merge origin/feature/ARSN-184-type-check-s3routes
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/feature/ARSN-184-type-check-s3routes

bert-e · 2022-05-25T09:29:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

bert-e · 2022-05-25T09:57:23Z

Conflict

A conflict has been raised during the update of
integration branch w/8.1/feature/ARSN-184-type-check-s3routes with contents from feature/ARSN-184-type-check-s3routes
and development/8.1.

Please resolve the conflict on the integration branch (w/8.1/feature/ARSN-184-type-check-s3routes).

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout w/8.1/feature/ARSN-184-type-check-s3routes
 $ git pull  # or "git reset --hard origin/w/8.1/feature/ARSN-184-type-check-s3routes"
 $ git merge origin/development/8.1
 $ # <intense conflict resolution>
 $ git commit
 $ git merge origin/feature/ARSN-184-type-check-s3routes
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/feature/ARSN-184-type-check-s3routes

bert-e · 2022-05-25T09:58:53Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

ghivert · 2022-05-25T09:59:44Z

/approve

bert-e · 2022-05-25T10:05:52Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/7.10
✔️ development/8.1

The following branches will NOT be impacted:

development/6.4
development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2022-05-25T10:05:58Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.10
✔️ development/8.1

The following branches have NOT changed:

development/6.4
development/7.4

Please check the status of the associated issue ARSN-184.

Goodbye ghivert.

ghivert added 15 commits May 6, 2022 14:26

ARSN-184 Move all .js to .ts files

8784113

ARSN-184 Fix StatsClient

670d57a

ARSN-184 Type check routes

4eba3ca

ARSN-184 Type check routesUtils

1c7122b

ARSN-184 WIP Routes

2cc1a98

ARSN-184 Type check routesUtils

60139ab

ARSN-184 Type check routes

18b089f

ARSN-184 Type check routeDELETE

283a086

ARSN-184 Type check routeGET

a98f2ce

ARSN-184 Type check routeHEAD

3fab050

ARSN-184 Type check routeOPTIONS

7cecbe2

ARSN-184 Type check routePOST

4131732

ARSN-184 Type check routePUT

72bdd13

ARSN-184 Type check routeWebsite

26de19b

ARSN-184 Exports

75811ba

ghivert changed the base branch from development/8.1 to development/7.10 May 6, 2022 12:48

bert-e mentioned this pull request May 6, 2022

INTEGRATION [PR#1878 > development/8.1] ARSN-184 type check s3routes #1879

Merged

ARSN-184 Remove useless signatures

d6e4bca

jbertran approved these changes May 12, 2022

View reviewed changes

nicolas2bert approved these changes May 24, 2022

View reviewed changes

Merge remote-tracking branch 'origin/development/7.10' into HEAD

75c5c85

Fix TODOs

f1478cb

Fix TODOs

571128e

scality deleted a comment from bert-e May 25, 2022

bert-e merged commit 571128e into development/7.10 May 25, 2022

bert-e deleted the feature/ARSN-184-type-check-s3routes branch May 25, 2022 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARSN-184 type check s3routes #1878

ARSN-184 type check s3routes #1878

ghivert commented May 6, 2022

bert-e commented May 6, 2022

bert-e commented May 6, 2022

bert-e commented May 6, 2022

bert-e commented May 6, 2022

bert-e commented May 6, 2022

nicolas2bert left a comment

nicolas2bert May 24, 2022

jbertran May 25, 2022

nicolas2bert May 24, 2022

jbertran May 25, 2022

bert-e commented May 24, 2022

bert-e commented May 25, 2022

bert-e commented May 25, 2022

bert-e commented May 25, 2022

bert-e commented May 25, 2022

ghivert commented May 25, 2022

bert-e commented May 25, 2022

bert-e commented May 25, 2022

ARSN-184 type check s3routes #1878

ARSN-184 type check s3routes #1878

Conversation

ghivert commented May 6, 2022

bert-e commented May 6, 2022

Hello ghivert,

bert-e commented May 6, 2022

Branches have diverged

bert-e commented May 6, 2022

Conflict

bert-e commented May 6, 2022

Integration data created

bert-e commented May 6, 2022

Waiting for approval

nicolas2bert left a comment

Choose a reason for hiding this comment

nicolas2bert May 24, 2022

Choose a reason for hiding this comment

jbertran May 25, 2022

Choose a reason for hiding this comment

nicolas2bert May 24, 2022

Choose a reason for hiding this comment

jbertran May 25, 2022

Choose a reason for hiding this comment

bert-e commented May 24, 2022

Conflict

bert-e commented May 25, 2022

Conflict

bert-e commented May 25, 2022

Waiting for approval

bert-e commented May 25, 2022

Conflict

bert-e commented May 25, 2022

Waiting for approval

ghivert commented May 25, 2022

bert-e commented May 25, 2022

In the queue

bert-e commented May 25, 2022