Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-185 Type Check patches/locationConstraints #1862

Merged
merged 3 commits into from
May 12, 2022

Conversation

ghivert
Copy link
Contributor

@ghivert ghivert commented May 3, 2022

No description provided.

@bert-e
Copy link
Contributor

bert-e commented May 3, 2022

Hello ghivert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 3, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-185 contains:

  • 7.10.23

  • 8.1.45

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.45

Please check the Fix Version/s of ARSN-185, or the target
branch of this pull request.

@ghivert
Copy link
Contributor Author

ghivert commented May 3, 2022

Bloop

@bert-e
Copy link
Contributor

bert-e commented May 3, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

let pathStyle = process.env.CI_CEPH !== undefined;

switch (l.locationType) {
case 'location-mem-v1':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make locationType a literal union?


switch (l.locationType) {
case 'location-mem-v1':
location.type = 'mem';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for type I guess

@bert-e
Copy link
Contributor

bert-e commented May 12, 2022

Conflict

There is a conflict between your branch feature/ARSN-185-type-check-patches and the
destination branch development/8.1.

Please resolve the conflict on the feature branch (feature/ARSN-185-type-check-patches).

git fetch && \
git checkout origin/feature/ARSN-185-type-check-patches && \
git merge origin/development/8.1

Resolve merge conflicts and commit

git push origin HEAD:feature/ARSN-185-type-check-patches

@bert-e
Copy link
Contributor

bert-e commented May 12, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@ghivert
Copy link
Contributor Author

ghivert commented May 12, 2022

/approve

@bert-e
Copy link
Contributor

bert-e commented May 12, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 12, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-185.

Goodbye ghivert.

@bert-e bert-e merged commit 10cf10d into development/8.1 May 12, 2022
@bert-e bert-e deleted the feature/ARSN-185-type-check-patches branch May 12, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants