-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARSN-185 Type Check patches/locationConstraints #1862
Conversation
Hello ghivert,My role is to assist you with the merge of this Status report is not available. |
Bloop |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
lib/patches/locationConstraints.ts
Outdated
let pathStyle = process.env.CI_CEPH !== undefined; | ||
|
||
switch (l.locationType) { | ||
case 'location-mem-v1': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make locationType
a literal union?
lib/patches/locationConstraints.ts
Outdated
|
||
switch (l.locationType) { | ||
case 'location-mem-v1': | ||
location.type = 'mem'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for type
I guess
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/feature/ARSN-185-type-check-patches && \
git merge origin/development/8.1 Resolve merge conflicts and commit git push origin HEAD:feature/ARSN-185-type-check-patches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-185. Goodbye ghivert. |
No description provided.