-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/arsn 177 introduce archive field in metadata #1856
Feature/arsn 177 introduce archive field in metadata #1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
642ef25
to
0e1b895
Compare
882dea9
to
bca296c
Compare
3e5a2bf
to
af71f12
Compare
7c740a4
to
da9090d
Compare
d735a57
to
11106e9
Compare
158cf7d
to
f8881ef
Compare
11106e9
to
a0babc8
Compare
f8881ef
to
25ae7e4
Compare
888c853
to
8bfe1a5
Compare
8bfe1a5
to
b3cf9e8
Compare
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1856 +/- ##
===================================================
+ Coverage 63.00% 63.26% +0.25%
===================================================
Files 201 203 +2
Lines 15421 15535 +114
Branches 3076 3101 +25
===================================================
+ Hits 9716 9828 +112
- Misses 5690 5692 +2
Partials 15 15
Continue to review full report at Codecov.
|
Hello williamlardier,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
9d03c24
to
f87101e
Compare
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-177. Goodbye williamlardier. |
This new metadata field is introduced as part of the Cold Storage epic.
The suggested format is a class in the same way as #1855.
Here, we enforce a specific order of fields edition:
archiveInfo
is required when creating the objectrestoreRequestedAt
andrestoreRequestedDays
can be only set ifarchiveInfo
is set (because the latter is mandatory when creating the object)restoreCompletedAt
andrestoreWillExpireAt
can be only set ifrestoreRequestedAt
andrestoreRequestedDays
are set, because the restoration completion comes after the restoration request.Once the object is restored and the restoration expires, the
archive
field can be re-computed by keeping thearchiveInfo
field only.The field setter will make sure the provided object is of the right type or is valid using the
isValid
static function of the new class.Unit tests are added to make sure the class behave as expected.