Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RestoreObject API action and permission #1854

Merged
merged 3 commits into from
May 5, 2022

Conversation

williamlardier
Copy link
Contributor

Added Fujifilm as the author of the second commit.

@bert-e
Copy link
Contributor

bert-e commented May 3, 2022

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@scality scality deleted a comment from bert-e May 3, 2022
@bert-e
Copy link
Contributor

bert-e commented May 3, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1854 (7f93695) into development/8.1 (0e3edb8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           development/8.1    #1854      +/-   ##
===================================================
- Coverage            62.95%   62.94%   -0.02%     
===================================================
  Files                  199      199              
  Lines                15407    15410       +3     
  Branches              3053     3054       +1     
===================================================
  Hits                  9700     9700              
- Misses                5706     5709       +3     
  Partials                 1        1              
Impacted Files Coverage Δ
lib/policyEvaluator/utils/actionMaps.ts 100.00% <ø> (ø)
lib/s3routes/routes/routePOST.js 10.34% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3edb8...7f93695. Read the comment docs.

@nicolas2bert
Copy link
Contributor

You might also need to update the const actionMonitoringMapS3.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 5, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 5, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-179.

Goodbye williamlardier.

@bert-e bert-e merged commit 59f7e32 into development/8.1 May 5, 2022
@bert-e bert-e deleted the feature/ARSN-179-support-restore-object branch May 5, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants