Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump node-forge from 0.7.6 to 0.10.0 #1258

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2020

Bumps node-forge from 0.7.6 to 0.10.0.

Changelog

Sourced from node-forge's changelog.

0.10.0 - 2019-09-01

Changed

  • BREAKING: Node.js 4 no longer supported. The code may still work, and non-invasive patches to keep it working will be considered. However, more modern tools no longer support old Node.js versions making testing difficult.

Removed

  • BREAKING: Remove util.getPath, util.setPath, and util.deletePath. util.setPath had a potential prototype pollution security issue when used with unsafe inputs. These functions are not used by forge itself. They date from an early time when forge was targeted at providing general helper functions. The library direction changed to be more focused on cryptography. Many other excellent libraries are more suitable for general utilities. If you need a replacement for these functions, consier get, set, and unset from lodash. But also consider the potential similar security issues with those APIs.

0.9.2 - 2019-09-01

Changed

  • Added util.setPath security note to function docs and to README.

Notes

  • SECURITY: The util.setPath function has the potential to cause prototype pollution if used with unsafe input.
    • This function is not used internally by forge.
    • The rest of the library is unaffected by this issue.
    • Do not use unsafe input with this function.
    • Usage with known input should function as expected. (Including input intentionally using potentially problematic keys.)
    • No code changes will be made to address this issue in 0.9.x. The current behavior could be considered a feature rather than a security issue. 0.10.0 will be released that removes util.getPath and util.setPath. Consider get and set from lodash if you need replacements. But also consider the potential similar security issues with those APIs.
    • https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677
    • https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7720

0.9.1 - 2019-09-26

Fixed

  • Ensure DES-CBC given IV is long enough for block size.

0.9.0 - 2019-09-04

Added

  • Add ed25519.publicKeyFromAsn1 and ed25519.privateKeyFromAsn1 APIs.
  • A few OIDs used in EV certs.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 2, 2020
@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2020

Hello dependabot[bot],

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2020

Conflict

A conflict has been raised during the creation of
integration branch w/7.8/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 with contents from dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0
and development/7.8.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.8/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 origin/development/7.8
 $ git merge origin/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.8/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0

@bert-e
Copy link
Contributor

bert-e commented Apr 9, 2021

Conflict

There is a conflict between your branch dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 and the
destination branch development/7.4.

Please resolve the conflict on the feature branch (dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0).

 $ git fetch
 $ git checkout origin/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0
 $ git merge origin/development/7.4
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 branch from 17dd938 to 6cd9ed1 Compare April 9, 2021 00:56
@bert-e
Copy link
Contributor

bert-e commented Apr 9, 2021

Conflict

A conflict has been raised during the creation of
integration branch w/7.10/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 with contents from dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0
and development/7.10.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.10/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 origin/development/7.10
 $ git merge origin/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.10/dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0

@rahulreddy rahulreddy closed this May 12, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 12, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 branch May 12, 2021 21:54
@bert-e bert-e restored the dependabot/npm_and_yarn/development/7.4/node-forge-0.10.0 branch May 12, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants