feat(instance): add a WaitForImage method#381
Merged
jerome-quere merged 8 commits intoscaleway:masterfrom Apr 17, 2020
Merged
Conversation
golangcibot
reviewed
Apr 17, 2020
Sh4d1
suggested changes
Apr 17, 2020
jerome-quere
force-pushed
the
wait-for-image
branch
from
0948899 to
24f3087
Compare
Sh4d1
reviewed
Apr 17, 2020
| type WaitForImageRequest struct { | ||
| ImageID string | ||
| Zone scw.Zone | ||
| Timeout time.Duration |
Contributor
There was a problem hiding this comment.
I know instance doesn't use pointers here, but shouldn't it be better?
Contributor
Author
There was a problem hiding this comment.
I want to stay consistent with WaitForServer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.