Skip to content

feat(core): support more instance error types #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuentinBrosse merged 3 commits into from
Dec 23, 2019
Merged

feat(core): support more instance error types #278

QuentinBrosse merged 3 commits into from
Dec 23, 2019

Conversation

@QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Dec 20, 2019

Converssions:

  • Error type invalid_request_error with fields field => InvalidArgumentsError
  • Error type invalid_request_error without fields field and with message field => ResponseError
  • Error type conflict => ResponseError

See errors_test.go for more details.

kindermoumoute
kindermoumoute reviewed Dec 23, 2019
View reviewed changes
kindermoumoute
kindermoumoute requested changes Dec 23, 2019
View reviewed changes
kindermoumoute
kindermoumoute approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit d93f0d4 into scaleway:master Dec 23, 2019
@QuentinBrosse QuentinBrosse deleted the support-more-instance-errors branch December 23, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuentinBrosse @kindermoumoute