Skip to content

feat(core): handle non standard errors #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kindermoumoute merged 2 commits into from
Dec 12, 2019
Merged

feat(core): handle non standard errors #274

kindermoumoute merged 2 commits into from
Dec 12, 2019

Conversation

@kindermoumoute
Copy link
Contributor

@kindermoumoute kindermoumoute commented Dec 12, 2019 •
edited
Loading

+ fix: always return error interface

jerome-quere
jerome-quere approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 7fdf948 into scaleway:master Dec 12, 2019
@kindermoumoute kindermoumoute deleted the handle-instance-non-standard-error branch December 12, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jerome-quere jerome-quere jerome-quere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kindermoumoute @jerome-quere