Skip to content

fix(instance): allow image to be empty in CreateServer #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerome-quere merged 1 commit into from
Sep 18, 2019
Merged

fix(instance): allow image to be empty in CreateServer #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/instance/v1/server_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type CreateServerRequest createServerRequest
func (s *API) CreateServer(req *CreateServerRequest, opts ...scw.RequestOption) (*CreateServerResponse, error) {

// If image is not a UUID we try to fetch it from marketplace.
if !uuid.IsUUID(req.Image) {
if req.Image != "" && !uuid.IsUUID(req.Image) {
apiMarketplace := marketplace.NewAPI(s.client)
imageId, err := apiMarketplace.GetLocalImageIDByLabel(&marketplace.GetLocalImageIDByLabelRequest{
ImageLabel: req.Image,
Expand Down