Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find transaction in transaction group by id #778

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Sep 6, 2022

  1. Find transaction in transaction group by id

    Without this change `txn GroupIndex` can inappropriately return `-1` despite all fields of `tx` are the same as all fields of `gtxns[x]`. Apparently, the reason is that either `tx` or `gtxns` can be overwritten at some point by the same content but stored in different memory location (`indexOf` uses `===` which compares objects *by reference*).
    
    I had this problem when providing liquidity twice in a row in Pact smart contract (https://github.com/pactfi/algorand-testbed/blob/master/constant_product.teal)
    MetaB0y authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    61c1909 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Update txn.ts

    robert-zaremba authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    d36177f View commit details
    Browse the repository at this point in the history
  2. fix

    robert-zaremba authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    5caaac2 View commit details
    Browse the repository at this point in the history