-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xsbt-web-plugin 4.2.4 -> sbt-war 5.0.0-M2 #131
Conversation
@@ -14,7 +14,7 @@ | |||
$ sbt new scalatra/scalatra.g8 | |||
$ cd <name-of-app> | |||
$ sbt | |||
> Jetty/start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might require other documentation updates around the Scalatra ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we will work on it once this PR is merged.
Thank you for raising this. Looks like we need to fix CI😅 Will work on it in another PR. |
@earldouglas CI has been fixed in the master branch. Could you rebase this pull request on it?
In theory, using Tomcat wouldn't be a problem as Scalatra is a pure servlet-based framework which doesn't rely on container specific features. However, Jetty is used for many purposes in Scalatra, like integration test support, standalone deployment, etc. So, it would be better to use Jetty by default if possible. |
Thanks!
Gotcha. I'll experiment with using Jetty by default instead. Marking this PR as draft until these are both addressed:
|
It seems that we have migrated to sbt-war last week: 394f837 However, it doesn't work for some reason. I tried below:
Tomcat launched but 404 is returned for cc: @magnolia-k |
I tested it on both Linux (Ubuntu 24.4) and macOS 15.2 (both using JDK 21), and I was able to confirm that the screen is displayed at http://localhost:8080. |
I was using Java 11. Switching to Java 17/21 worked. 🙇♂️ |
@earldouglas While I confirmed sbt-web works, I have some questions about sbt-web to replace xsb-web-plugin.
|
@takezoe These are excellent questions; thanks! I'll answer them in the sbt-war readme, and also copy/link the answers here. |
@earldouglas Thank you! No need to comment here in that case. I will look at READMD of sbt-war. |
We might want to wait for the non-milestone 5.0.0 release, in which case this PR can serve as a placeholder.
sbt-war 5 uses
com.heroku:webapp-runner
, which uses Tomcat (currently version 10.1.28, which targets the 6.0 servlet spec); would we want to use the Eclipse Jetty runner instead?