GeneratedEnum and GeneratedOneof extends Product #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before ``` scala> import com.trueaccord.proto.e2e.one_of.OneofTest import com.trueaccord.proto.e2e.one_of.OneofTest scala> List(OneofTest.MyOneOf.Empty, OneofTest.MyOneOf.Sub(OneofTest.SubMessage())) res0: List[com.trueaccord.proto.e2e.one_of.OneofTest.MyOneOf with Product] = List(Empty, Sub()) scala> import com.trueaccord.proto.e2e.enum3.Color3 import com.trueaccord.proto.e2e.enum3.Color3 scala> Color3.values res1: Seq[com.trueaccord.proto.e2e.enum3.Color3 with Product] = List(C3_UNKNOWN, C3_RED, C3_GREEN, C3_BLUE) scala> List(Color3.C3_RED, Color3.C3_BLUE) res2: List[com.trueaccord.proto.e2e.enum3.Color3 with Product] = List(C3_RED, C3_BLUE) ``` after ``` scala> import com.trueaccord.proto.e2e.one_of.OneofTest import com.trueaccord.proto.e2e.one_of.OneofTest scala> List(OneofTest.MyOneOf.Empty, OneofTest.MyOneOf.Sub(OneofTest.SubMessage())) res0: List[com.trueaccord.proto.e2e.one_of.OneofTest.MyOneOf] = List(Empty, Sub()) scala> import com.trueaccord.proto.e2e.enum3.Color3 import com.trueaccord.proto.e2e.enum3.Color3 scala> Color3.values res1: Seq[com.trueaccord.proto.e2e.enum3.Color3] = List(C3_UNKNOWN, C3_RED, C3_GREEN, C3_BLUE) scala> List(Color3.C3_RED, Color3.C3_BLUE) res2: List[com.trueaccord.proto.e2e.enum3.Color3] = List(C3_RED, C3_BLUE) ``` same fix in Scala std library - scala/scala@da6ef7b7d4cfd4849499e28c7f0f6 - scala/scala@226c4df186150d7773fa7cd9ad68
thesamet
added a commit
that referenced
this pull request
Nov 27, 2015
GeneratedEnum and GeneratedOneof extends Product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
same fix in Scala std library