-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any plan to support GRPC? #44
Comments
👍 I've modified the Java GRPC compiler to create Scala service stubs instead. I'd be interested in porting that work over if it's something others are interested in. We'd also need proto3 support. I think we're close, there doesn't seem to be a big difference between the two. The biggest change needed I've found is for all fields to be optional. |
@zackangelo |
I am woking on scala gRPC support with @xuwei-k. We will fork ScalaPB rather than sending pull requests to get things done quickly. Let us know if you have any concerns. This issue will be closed in a few days. |
@tayama0324 nice, would definitely love to have it merged here when you're ready. |
About making all fields optional: can this be a setting, so I can choose to make all fields non-optional, instead? Wrapping everything in an Option can become too much overhead. The proto3 semantics allow for this (see this example). |
@iphydf the above comment seem to be unrelated to this bug - can you please file a different issue? FWIW, in Scalapb >= 0.5, primitives are not wrapped in an Option for proto3. |
@xuwei-k @tayama0324 can I help you and contribute some code? I want to use grpc at work. |
Status update: merge @xuwei-k PR into the grpc branch here. Added an implementation of a Marshaller to avoid conversions to/from Java protobufs. |
Excellent! thanks a lot 😄 |
The work has been merged into master and released in 0.5.18. Thanks @xuwei-k for doing the heavy lifting! |
FYI, I and @tayama0324 translated grpc-java examples. https://github.com/xuwei-k/grpc-scala-sample |
This is really awesome - thank you! When I get to write the docs for On Fri, Dec 18, 2015 at 8:04 PM, kenji yoshida [email protected]
-Nadav |
This is great. Can you show us (java guys) a few hints on where to look for the code for implementing grpc on our projects @xuwei-k and @tayama0324 in https://github.com/xuwei-k/grpc-scala-sample. Thanks a lot for this excellent work. |
Documentation: https://scalapb.github.io/grpc.html |
http://www.grpc.io/
The text was updated successfully, but these errors were encountered: