Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalaPB jar includes google proto files #33

Closed
iphydf opened this issue Jul 21, 2015 · 2 comments
Closed

ScalaPB jar includes google proto files #33

iphydf opened this issue Jul 21, 2015 · 2 comments

Comments

@iphydf
Copy link

iphydf commented Jul 21, 2015

google/protobuf/descriptor.proto is both in scalapb-runtime and in protobuf-java jars. This is a problem when using ScalaPB on Android.
@thesamet
Copy link
Contributor

What problem is it causing? Can you provide an error message?

@iphydf
Copy link
Author

iphydf commented Jul 21, 2015 

[error] (android:apkbuild) com.android.builder.packaging.DuplicateFileException: Duplicate files copied in APK google/protobuf/descriptor.proto
[error]     File 1: $HOME/.ivy2/local/com.trueaccord.scalapb/scalapb-runtime_2.11/0.5.10-SNAPSHOT/jars/scalapb-runtime_2.11.jar
[error]     File 2: $HOME/.ivy2/cache/com.google.protobuf/protobuf-java/bundles/protobuf-java-3.0.0-alpha-3.jar

thesamet added a commit that referenced this issue Aug 23, 2015
@thesamet
Move Google protobuf to third_party directory.
00edff8 
Fixes #33.

Conflicts:
	compiler-plugin/src/main/java/com/google/protobuf/compiler/PluginProtos.java
	compiler-plugin/src/main/java/com/trueaccord/scalapb/Scalapb.java
	scalapb-runtime/src/main/java/com/trueaccord/scalapb/Scalapb.java
	scalapb-runtime/src/main/scala/com/trueaccord/scalapb/Encoding.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thesamet @iphydf