bugfix: Don't use aggregate in Scala Native #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
requested changes
Feb 16, 2025
build.sbt
Outdated
| @@ -229,7 +229,7 @@ lazy val cli = crossProject(JVMPlatform, NativePlatform, JSPlatform) | |||
| // TODO: enable NPM publishing | |||
| .jsSettings(scalaJsSettings, scalaJSUseMainModuleInitializer := true) | |||
| .jvmEnablePlugins(NativeImagePlugin) | |||
| .jvmConfigure(_.dependsOn(dynamic.jvm).aggregate(dynamic.jvm)).aggregate(core) | |||
| .jvmConfigure(_.dependsOn(dynamic.jvm).aggregate(dynamic.jvm).aggregate(core.jvm)) | |||
There was a problem hiding this comment.
the purpose of this aggregation was only to be able to run cliXxx/test and get tests from dependencies (in reality, only sysops).
so, in this case, we should remove this aggregation for all platforms and either:
- add
coreXxx/testtoci-test-xxxcommands - or move
.aggregate(core)to thetestsproject.
There was a problem hiding this comment.
I added it to tests instead.
This causes the nativeLink task to be executed for all the modules and it doesn't make sense to do that for non app modules.
kitbellew
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the nativeLink task to be executed for all the modules and it doesn't make sense to do that for non app modules.