Don't use deprecated scalameta methods #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Dec 28, 2022
Comment on lines
2076
to
2078
| case ParamClauseParent( | ||
| t @ Defn.ExtensionGroup.internal.Impl(_, b: Term.Block) | ||
| ) if isBlockStart(b, nft) => |
There was a problem hiding this comment.
Suggested change
| case ParamClauseParent( | |
| t @ Defn.ExtensionGroup.internal.Impl(_, b: Term.Block) | |
| ) if isBlockStart(b, nft) => | |
| case ParamClauseParent( | |
| t : Defn.ExtensionGroup | |
| ) if isBlockStart(t.body, nft) => |
I would avoid using the internal Impl classes since they might not be binary compatible.
| Some(new OptionalBracesRegion { | ||
| def owner = Some(t) | ||
| def splits = Some(getSplitsMaybeBlock(ft, nft, b)) | ||
| def rightBrace = blockLast(b) | ||
| }) | ||
| case t @ Term.If(_, thenp, _) if !nft.right.is[T.KwThen] && { | ||
| case t @ Term.If.internal.Impl(_, thenp, _, _) |
There was a problem hiding this comment.
Suggested change
| case t @ Term.If.internal.Impl(_, thenp, _, _) | |
| case t : Term.If |
and then just use t.thenp
| Some(new OptionalBracesRegion { | ||
| def owner = Some(t) | ||
| def splits = Some(getSplitsMaybeBlock(ft, nft, b)) | ||
| def rightBrace = blockLast(b) | ||
| }) | ||
| case t @ Term.If(_, thenp, _) if !nft.right.is[T.KwThen] && { | ||
| case t @ Term.If.internal.Impl(_, thenp, _, _) |
There was a problem hiding this comment.
Suggested change
| case t @ Term.If.internal.Impl(_, thenp, _, _) | |
| case t : Term.If |
and then just use t.thenp.
Also in other places in the file
There was a problem hiding this comment.
will do. however, why would we need (or expect) binary compatibility here? for every upgrade of the parser, we explicitly modify the formatter. the whole point to add those internal.Impl.unapply methods was for a case like this.
There was a problem hiding this comment.
Hmm... binary compat might not be a problem yeah. Maybe I went overeager, but I still think it's a bit easier to just annotate type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.