Implement changes from Intellij Code Inspection #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
code
branch
2 times, most recently
from
96eba75 to
aa761c7
Compare
tgodzik
approved these changes
Feb 3, 2022
Comment on lines
80
to
82
| val src = Source.fromFile(atFile) | ||
| try builder ++= src.getLines() | ||
| finally src.close() |
There was a problem hiding this comment.
You could also use scala.util.Using
Suggested change
| val src = Source.fromFile(atFile) | |
| try builder ++= src.getLines() | |
| finally src.close() | |
| builder ++= Using.resource(Source.fromFile(atFile))(_.getLines()) |
There was a problem hiding this comment.
done, thank you, didn't know about this
There was a problem hiding this comment.
it's only available for scala 2.13. added this package for 2.12:
https://index.scala-lang.org/bigwheel/util-backports/util-backports/2.1
Comment on lines
84
to
86
| val src = scala.io.Source.fromURL(url) | ||
| try src.getLines().mkString("", "\n", "\n") | ||
| finally src.close() |
There was a problem hiding this comment.
Suggested change
| val src = scala.io.Source.fromURL(url) | |
| try src.getLines().mkString("", "\n", "\n") | |
| finally src.close() | |
| builder ++= Using.resource(scala.io.Source.fromURL(url))(_.getLines().mkString("", "\n", "\n")) |
or something along these lines
kitbellew
commented
Feb 4, 2022
Comment on lines
80
to
82
| val src = Source.fromFile(atFile) | ||
| try builder ++= src.getLines() | ||
| finally src.close() |
There was a problem hiding this comment.
done, thank you, didn't know about this
Comment on lines
84
to
86
| val src = scala.io.Source.fromURL(url) | ||
| try src.getLines().mkString("", "\n", "\n") | ||
| finally src.close() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.