Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scalameta v3.7 #1170

Merged
merged 3 commits into from
May 11, 2018
Merged

Conversation

olafurpg
Copy link
Member

Scalafmt has been on an old Scalameta past year version due to the removal of scalameta/paradise macro annotations in Scalameta v2.0. Thanks to #1145, scalafmt no longer uses those macro annotations so now we can upgrade from v1.8 (which was released May 22 last year) straight to 3.7 (which was released a couple weeks ago). This upgrade opens a lot of exciting opportunities

  • scalafmt can use scalafix for rewriting and throw out its own rewrite infrastructure 🤝
  • as soon as scalameta is published for scala native we'll have scalafmt on native 🚀
  • sbt-scalafmt and sbt-scalafix can live on the same classpath ☮️
  • metals can use scalafmt without coursier + classloading hacks 🙏

Fixes #975

olafurpg added 3 commits May 10, 2018 16:20
The table in https://github.com/scalameta/scalameta/releases/tag/v2.0.0
was extra helpful to know how to do the renames.
Most of this commit was automated with find+sed

```
find . -type f -name '*.scala' -exec sed -i '' 's/Pat.Var.Type/Type.Var/g' {} +
```
@olafurpg olafurpg force-pushed the the-great-upgrade branch from 3fc2baa to 1b83b82 Compare May 10, 2018 15:09
@olafurpg olafurpg requested a review from xeno-by May 10, 2018 15:09
@olafurpg
Copy link
Member Author

Opened PR enabling cross-building for Scala Native in Scalameta scalameta/scalameta#1529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Scalameta dependency
1 participant