Update github workflows #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mzuehlke
commented
Feb 27, 2023
•
mzuehlke
commented
- olafurpg/setup got deprecated in https://github.com/olafurpg/setup-scala/releases/tag/v14
- replaced by actions/setup-java@v3
- enabled sbt caching
- olafurpg/setup-gpg is no longer required since sbt-ci-release v1.5.5
tgodzik
reviewed
Feb 27, 2023
.github/workflows/ci.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: olafurpg/setup-scala@v13 | ||
| - uses: actions/setup-java@3 |
There was a problem hiding this comment.
Suggested change
| - uses: actions/setup-java@3 | |
| - uses: actions/setup-java@v3 |
I think 2 is the latest
There was a problem hiding this comment.
There was a problem hiding this comment.
actions/setup-java@v3 it looks like it needs the v then 🤔
mzuehlke
force-pushed
the
github_workflow_maintenance
branch
from
2086a22 to
012dfc6
Compare
|
I forgot to amend my last commit, will you squash them when merging ? |
tgodzik
requested changes
Feb 27, 2023
* olafurpg/setup got deprecated in v14 * replaced by actions/setup-java@v3 * enabled sbt caching * olafurpg/setup-gpg is no longer required since sbt-ci-release v1.5.5
mzuehlke
force-pushed
the
github_workflow_maintenance
branch
from
2d6ccea to
673c4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.