scalafix 0.10.1 #560
Merged
scalafix 0.10.1 #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of sbt-scalafix 0.10.0, scala version is not overriden by scalafixEnable, so running with ++2.12.10 would result in "type nowarn is not a member of package annotation" as nowarn was introduced in 2.12.13 and sbt macros generate code that uses it
bjaglin
commented
Jul 15, 2022
| @@ -41,11 +41,11 @@ mimaPreviousArtifacts := Set.empty | |||
| crossScalaVersions := List() | |||
| addCommandAlias( | |||
| "scalafixAll", | |||
| "; ++2.12.10 ; scalafixEnable ; all scalafix test:scalafix" | |||
There was a problem hiding this comment.
before scalacenter/sbt-scalafix#292, the patch version was ignored as sbt-scalafix uses to set its own version (2.13 or later, containing nowarn, and thus building fine with recent versions of sbt using that nowarn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550
Closes #537
Follows #513 (comment)
As of
sbt-scalafix0.10.0, scala version is no longer overriden byscalafixEnable, so running with++2.12.10would result in "type nowarn is not a member of package annotation" asnowarnwas introduced in 2.12.13 and sbt macros generate code that uses it.