Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unitToProp implicit conversion #449

Merged
merged 2 commits into from
Oct 24, 2021
Merged

Fix unitToProp implicit conversion #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4245f7
Fix unitToProp implicit conversion
armanbilge Oct 24, 2021
aac4820
Add MiMa exclusion
armanbilge Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ lazy val mimaEnable: List[Def.Setting[_]] = List(
),
ProblemFilters.exclude[IncompatibleMethTypeProblem](
"munit.ValueTransforms#ValueTransform.this"
),
ProblemFilters.exclude[DirectMissingMethodProblem](
"munit.ScalaCheckSuite.unitToProp"
)
),
mimaPreviousArtifacts := {
Expand Down
2 changes: 1 addition & 1 deletion munit-scalacheck/shared/src/main/scala/munit/ScalaCheckSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ trait ScalaCheckSuite extends FunSuite {
// Allow property bodies of type Unit
// This is done to support using MUnit assertions in property bodies
// instead of returning a Boolean.
implicit def unitToProp: Unit => Prop = _ => Prop.passed
implicit def unitToProp(unit: Unit): Prop = Prop.passed

override def munitTestTransforms: List[TestTransform] =
super.munitTestTransforms :+ scalaCheckPropTransform
Expand Down