Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a FunSuite trait while preserving API #289

Closed
wants to merge 2 commits into from
Closed

Expose a FunSuite trait while preserving API #289

wants to merge 2 commits into from

Conversation

vincenzobaz
Copy link

This PR addresses issue #288

Base automatically changed from master to main January 20, 2021 08:13
@vincenzobaz vincenzobaz marked this pull request as ready for review February 23, 2021 08:50
@julienrf
Copy link

@vincenzobaz would it be possible to keep binary compatibility by having the same constructor signatures, or maybe by adding them back as secondary constructors?

https://github.com/scalameta/munit/pull/289/checks?check_run_id=1959596809#step:4:249

@olafurpg
Copy link
Member

Thank you for this contribution! I opened #433 which implements this change on top of the latest master and uses the name BaseFunSuite instead of FunSuiteBase to prevent the situation where IDEs will auto-complete FunSuiteBase as you're typing FunSuite. This is a binary breaking change but that's OK since we're preparing a v1.0.0 release, which includes other binary breaking change like #418

@olafurpg olafurpg closed this Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincenzobaz @julienrf @olafurpg