Skip to content

Commit

Permalink
Merge pull request #601 from rpalcolea/issue-600/do-not-invoke-fireTe…
Browse files Browse the repository at this point in the history
…stStarted-for-ignored-tests

MUnitRunner: avoid invoking fireTestStarted if a test is skipped.
  • Loading branch information
tgodzik authored Nov 10, 2022
2 parents 0ec2259 + fa98de4 commit 47961eb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion munit/shared/src/main/scala/munit/MUnitRunner.scala
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,12 @@ class MUnitRunner(val cls: Class[_ <: Suite], newInstance: () => Suite)
return Future.successful(false)
}

notifier.fireTestStarted(description)
if (test.tags(Ignore)) {
notifier.fireTestIgnored(description)
return Future.successful(false)
}

notifier.fireTestStarted(description)
val onError: PartialFunction[Throwable, Future[Unit]] = {
case ex: AssumptionViolatedException =>
trimStackTrace(ex)
Expand Down

0 comments on commit 47961eb

Please sign in to comment.