Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies metals-languageclient to v.0.5.0 and vscode-languageclient to v.7.0.0 #541

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Update dependencies metals-languageclient to v.0.5.0 and vscode-languageclient to v.7.0.0 #541

merged 1 commit into from
Apr 19, 2021

Conversation

Giggiux
Copy link
Contributor

@Giggiux Giggiux commented Apr 19, 2021

This PR is needed to close scalameta/metals-feature-requests#202
It will update metals-languageclient to the latest released version
It will update vscode-languageclient to support LSP 3.16.0

@Giggiux Giggiux changed the title WIP: Update dependencies metals-languageclient to v.0.5.0 and vscode-languageclient to v.7.0.0 Update dependencies metals-languageclient to v.0.5.0 and vscode-languageclient to v.7.0.0 Apr 19, 2021
@tgodzik tgodzik requested a review from gabro April 19, 2021 12:36
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/extension.ts Outdated Show resolved Hide resolved
@tgodzik tgodzik requested a review from gabro April 19, 2021 12:52
@tgodzik
Copy link
Contributor

tgodzik commented Apr 19, 2021

Thanks @gabro for taking a look! I would have missed that one 😓

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tgodzik tgodzik merged commit 65f79ef into scalameta:main Apr 19, 2021
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
…rn/types/node-18.11.19

chore(deps-dev): bump @types/node from 18.11.18 to 18.11.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metals-vscode vscode-languageclient dependency to 7.0.0
3 participants