Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metals-languageserver and remove resolutions #259

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Apr 3, 2020

This pr updates the metals-languageserver for the primary purpose of being able to remove resolutions (which I needed for coc-metals 😆 ). I've built and tested locally, and everything seems to be working fine, typechecking, etc.

@ckipp01 ckipp01 requested a review from gabro April 3, 2020 07:18
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I’m glad to see those resolution go

@ckipp01 ckipp01 merged commit f2295ff into scalameta:master Apr 3, 2020
@ckipp01 ckipp01 deleted the update branch April 3, 2020 07:26
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
Fix github-changes to use the main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants