-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace vscode with @types/vscode #246
Conversation
Make sure to thoroughly test this, by publishing a vsix locally and installing it by hand. I’ve tried this in the past and the extension would not activate (i wasn’t able to pinpoint the exact issue), although it was working fine when launching it from the debugger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relevant code changes are 👍 I’ve left a few minor comments.
However I find the prettier change a bit distracting and out of scope for the PR.
Can we do the prettier 2 upgrade in a separate PR so that we keep this diff on this one more focused?
Also update other various dependencies
3992a14
to
65e961d
Compare
Sounds good 👍 I was able to do this with no issues.
Addressed the comments and made the changes.
Sure! I undid that update and I'll send in another pr for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot of tackling this! It was long due :-) LGTM 👏
…rn/types/node-14.14.32 Bump @types/node from 14.14.31 to 14.14.32
The main
vscode
dependency that we use has split up, and it's recommended to instead use@types/vscode
andvscode-test
. This pr replaces thevscode
dependency with@types-vscode
. I also update other various dependencies as a few of them were lagging behind which was causing some of the recent updates to not work right.https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode
vscode
dependencyFormat code with new version of prettierI did build locally and test installing the latest snapshot of metals, hovers, completions, debugging, and worksheets. Everything seems to be working as expected, but it's best if someone else also pulls this, builds it, and plays around with it, especially since I don't use vscode as my main editor. I'm probably the worst person to do this.