Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto Super Method functionality #233

Merged
merged 12 commits into from
Apr 10, 2020

Conversation

kpbochenek
Copy link
Contributor

Exposes functionality implemented in PR: scalameta/metals#1487

All functionality is described in mentioned PR, here I only expose those 2 functions implemented in metals

src/extension.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@kpbochenek
Copy link
Contributor Author

unrelated build failure:

Executing prepublish script 'yarn run vscode:prepublish'...
 ERROR  Command failed: yarn run vscode:prepublish
warning [email protected]: The engine "vscode" appears to be invalid.
error Command failed with exit code 2.

@gabro
Copy link
Member

gabro commented Mar 26, 2020

Can you run yarn vscode:prepublish directly and see whether you get better logs?

@gabro
Copy link
Member

gabro commented Mar 26, 2020

Actually, prepublish is just yarn compile so you can try that locally

@kpbochenek
Copy link
Contributor Author

kpbochenek commented Mar 26, 2020

Thanks it was actually by unused import :)

There is still one error but it doesn't cause build to fail

const serverOptions = getServerOptions({
    metalsClasspath,
    serverProperties,
    javaConfig,
    clientName: "vscode",
  });

is missing doctorFormat: "html" | "json";

EDIT:
Ok I need to update packages 👍

@gabro
Copy link
Member

gabro commented Mar 26, 2020

Ok I need to update packages 👍

You beat me to it :) We removed that option in a recent version of metals-languageclient

@tgodzik tgodzik merged commit f02f85e into scalameta:master Apr 10, 2020
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants