Delegate installJava to metals-languageclient #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not much to see here, self-merging |
I think if it's ok with you, I'd rather hold off on adding it. If anyone requests it or mentions that it'd be cool to have, then I'm more than happy to add it, but I really doubt that it will happen. |
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/semver-7.3.4 Bump semver from 7.3.2 to 7.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installJavautility now lives inmetals-languageclient/cc @ckipp01 in case you changed your mind and want to include this in coc-metals it's fairly easy now.