Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use checkoutv2 push rather than github-push-action #203

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Feb 5, 2020

Since we are using checkout/v2, we can just use push since it cache's the auth token allowing other authenticated git commands to work. I just put this in scalameta/coc-metals#65 and also ran a dummy test here in a sandbox to ensure that it indeed works.

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up

@ckipp01 ckipp01 merged commit fab23d1 into scalameta:master Feb 5, 2020
@ckipp01 ckipp01 deleted the ci-tweak branch February 5, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants