Some CI improvements #190
Merged
Some CI improvements #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gabro
commented
Feb 4, 2020
gabro
commented
- fix prettier check
- remove travis badge from README
- add publishing of VSIX to the latest release (the idea is that when the release workflow runs it was triggered by a release)
olafurpg
reviewed
Feb 4, 2020
.github/workflows/release.yml
Outdated
| @@ -22,7 +22,8 @@ jobs: | |||
| id: get_version | |||
| run: echo ::set-output name=NEW_VERSION::${GITHUB_REF#/refs/tags/v} | |||
| - run: yarn install | |||
| - run: yarn version --no-git-tag-version --new-version ${{ | |||
| - run: | |||
There was a problem hiding this comment.
This is needed to fix the interaction with prettier
Suggested change
| - run: | |
| - run: | |
olafurpg
reviewed
Feb 4, 2020
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| upload_url: { { steps.get_upload_url.outputs.UPLOAD_URL } } |
|
@olafurpg what do you think about triggering a release to see whether this works? |
|
@gabro sounds good! I think we have a few fixes in master that would be good to release as well |
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/types/node-14.11.8 Bump @types/node from 14.11.5 to 14.11.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.