Enable setting breakpoints in java and scala files #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Dec 10, 2019
| @@ -214,6 +214,14 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "breakpoints": [ | |||
There was a problem hiding this comment.
Is there a way to conditionally add this capability based on the server version? If not I guess we'll just have to live with it. The next stable version of Metals should come out soon
There was a problem hiding this comment.
Judging by the docs, I don't think so.
we use the breakpoints contribution point to list the languages for which setting breakpoints will be enabled. Without this, it would not be possible to set breakpoints
olafurpg
reviewed
Dec 10, 2019
There was a problem hiding this comment.
Let's merge this as soon as scalameta/metals#1163 is merged.
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/types/semver-7.3.2 Bump @types/semver from 7.3.1 to 7.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, metals didn't allow the user to set breakpoints in any file. Now, they can be set in any java or scala file.