allow to run main of different files in parallel #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Apr 8, 2024
| @@ -76,10 +76,10 @@ async function runMain(main: ExtendedScalaRunMain): Promise<boolean> { | |||
| }, | |||
| {} | |||
| ); | |||
|
|
|||
| const file = currentFile(); | |||
There was a problem hiding this comment.
This might prove problematic if we run but the file is not focused 🤔
Actually, we can already make it better via main.class which will be the name of the class being run, which should be unique.
There was a problem hiding this comment.
Good idea. testing it now.
tgodzik
reviewed
Apr 8, 2024
| @@ -79,7 +79,7 @@ async function runMain(main: ExtendedScalaRunMain): Promise<boolean> { | |||
|
|
|||
| const shellOptions = { ...platformSpecificOptions(), env }; | |||
| const task = new Task( | |||
| { type: "scala", task: "run" }, | |||
| { type: "scala " + main.data.class, task: "run" }, | |||
There was a problem hiding this comment.
Suggested change
| { type: "scala " + main.data.class, task: "run" }, | |
| { type: "scala", task: "run", class: main.data.class }, |
I read the API for Task and it seems type should stay as "scala" and we can just add another property which looks to be working. If we ever need to use https://code.visualstudio.com/api/extension-guides/task-provider#task-definition then we would avoid weird issue.
I should have thought of it in the first place, thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.