Use type array for serverProperties and customProperties settings #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
commented
Sep 6, 2019
| @@ -108,9 +108,7 @@ function fetchAndLaunchMetals(context: ExtensionContext, javaHome: string) { | |||
| : defaultServerVersion; | |||
| const serverProperties: string[] = workspace | |||
| .getConfiguration("metals") | |||
| .get<string>("serverProperties")! | |||
| .split(" ") | |||
| .filter(e => e.length > 0); | |||
There was a problem hiding this comment.
I've verified that the UI won't let you input a blank string (not even just spaces), so this I've removed this check.
Same thing below
tgodzik
approved these changes
Sep 6, 2019
|
@gabro I think we need to add some kind of migration - if user had a setting as string, we need to replace it with a lsit |
|
@tgodzik you are right, I'll work on a fix for this soon. |
|
This is awesome :D |
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/fp-ts-2.6.7 Bump fp-ts from 2.6.6 to 2.6.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from last July VSCode release, this type of setting finally has a UI 🎉