This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
New file command #73
Merged
New file command #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
commented
Feb 10, 2020
gabro
suggested changes
Feb 11, 2020
|
As always, thanks for the great review @gabro. I addressed the points and cleaned it up. |
- don't mix async/await and then/catch - add in some types - simplify the way we target file type selection
|
Fixed the last thing. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after reading scalameta/metals-vscode#183 I'm assuming this will change a bit, but I figured I'd create this pr just to show the initial idea I had about how to implement this. It seems to be working pretty well. 😄
I'm excited to start being able to use this feature. I've included a couple points/questions I'd love your input on @gabro.
closes #34