Use lenient dialect in scalafix-reflect. (Fix #543) #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag makes the parser fail in valid 2.x code where inline is an accepted identifier.
gabro
approved these changes
Jan 4, 2018
| @@ -77,7 +77,7 @@ object ScalafixConfig { | |||
| // Are extractor varargs specified using colons, i.e. is `case Extractor(xs: _*)` legal or not? | |||
| allowColonForExtractorVarargs = true, | |||
| // Are inline vals and defs supported by this dialect? | |||
| allowInlineMods = true, | |||
| allowInlineMods = false, | |||
There was a problem hiding this comment.
I'm trying to minimize the breaking change by switching the parser. If a rule previously used inline as an identifier then it would compile with reflect before this commit but not after. It's the only custom flag in DefaultDialect that removes features from the original dialect, the other flags only enable the dialect to parse more files.
gabro
approved these changes
Jan 4, 2018
MasseGuillaume
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.