Add resultType extension method on Symbol #381
Conversation
| for { | ||
| symbol <- t.symbol | ||
| resultType <- symbol.resultType | ||
| } yield assert(resultType.structure == Type.Name("Boolean").structure) |
There was a problem hiding this comment.
is there a smarter way to compare trees?
There was a problem hiding this comment.
There is! import scala.meta.contrib._; q"a.b".isEqual(q"a.b.")
| val defaultDialect = | ||
| dialects.Scala212.copy(allowMethodTypes = true, allowTypeLambdas = true) | ||
|
|
||
| def resultType( |
There was a problem hiding this comment.
the name is up to debate. resultType is general enough, but it's a bit of a stretch when referring to simple val/var
There was a problem hiding this comment.
Result type is the correct nomenclature from scalac 👍
| val defaultDialect = | ||
| dialects.Scala212.copy(allowMethodTypes = true, allowTypeLambdas = true) | ||
|
|
||
| def resultType( |
There was a problem hiding this comment.
Result type is the correct nomenclature from scalac 👍
| def resultType(dialect: Dialect): Option[Type] = | ||
| denotation.flatMap(denot => | ||
| DenotationOps.resultType(symbol, denot, dialect)) | ||
| def resultType: Option[Type] = resultType(DenotationOps.defaultDialect) |
There was a problem hiding this comment.
Can we only keep this overload and let advanced users with custom dialects call DenotationOps.resultType(customDialect)?
| for { | ||
| symbol <- t.symbol | ||
| resultType <- symbol.resultType | ||
| } yield assert(resultType.structure == Type.Name("Boolean").structure) |
There was a problem hiding this comment.
There is! import scala.meta.contrib._; q"a.b".isEqual(q"a.b.")
|
We should filter out We need to upgrade Mima to 0.1.15 Line 17 in 6b8cccd |
|
@olafurpg I've added the mima change in this PR, so that we can test it on the spot. Hope you don't mind |
This seemed like a useful utility so I extracted it from
ExplicitResultTypes