OrganizeImports: don't leak state from one fix execution to another #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
dontsharestate
branch
from
a84c898
to
dd9c034
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
dontsharestate
branch
from
dd9c034
to
3d071fc
Compare
At best, this was causing memory leaks during an invocation. At worst, it was generating false negatives for unused import removals.
bjaglin
force-pushed
the
dontsharestate
branch
from
3d071fc
to
22cb445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At best, this was causing memory leaks during an invocation. At worst, it was generating false negatives for unused import removals.
Exposed by https://github.com/scalacenter/scalafix/pull/1800/files#r1477081552