rules capturing leading tokens can be suppressed with scalafix:ok #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Nov 9, 2023
Comment on lines
+426
to
+427
| // include line start in case the rule captures leading tokens | ||
| val start = EscapeOffset(t.pos.start - t.pos.startColumn) |
There was a problem hiding this comment.
this is the actual fix - the rest of the changes is to satisfy scalafix-tests/input/src/main/scala-2/test/escapeHatch/Issue694.scala
bjaglin
force-pushed
the
disablesyntax-wildcard
branch
from
3575180
to
866ded0
Compare
bjaglin
force-pushed
the
disablesyntax-wildcard
branch
from
866ded0
to
d038dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1889